[Html_ajax-svn] [178] implementation and examples for Urlencoded serializer

[Joshua Eichorn]

Arpad Ray wrote:

>On Friday 11 November 2005 18:40, Elizabeth Smith wrote:
>  
>
>>Packages in pear don't usually rely on php_compat - instead just do
>>if(!function_exists and either error out with instructions to use
>>php_compat or copy/paste a compatible implementation.  Lots of people
>>don't have pear_compat installed and this will die a horrible death for
>>them :).
>>
>>    
>>
>
>To clarify, the package doesn't rely on PHP_Compat. This serialization method 
>alone requires PHP 5, PHP_Compat, or some other implementation of 
>http_build_query().
>
>Since PHP_Compat provides a nice implementation I do think that should be 
>automatically checked for, I don't think duplicating that code here would 
>make sense.
>
>I've moved the check into the serialize() function, so that unserialize() by 
>itself doesn't require it, and made it trigger a user warning if the function 
>isn't defined and can't be included from PHP_Compat.
>
>I hope this prevents a few horrible deaths.
>  
>
I haven't looked at the actual code, but the target for HTML_AJAX is 
4.3.0+ so if this is in a non optional code path we should copy paste.

If its an optional code path requiring PHP_Compat for 4.3.0 is ok, but 
it should be documented somewhere.
-josh

>_______________________________________________
>Html_ajax-svn mailing list
>Html_ajax-svn at lists.bluga.net
>http://lists.bluga.net/mailman/listinfo/html_ajax-svn
>  
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.bluga.net/pipermail/html_ajax-svn/attachments/20051111/922ef0f9/attachment.html