[Html_ajax-svn] [445] formEncode works with an id or an object

[Arpad Ray]

These checks should use HTML_AJAX_Util.getType() instead of typeof since it 
could be a string object.

Arpad

On Monday 20 March 2006 02:05, lyaish at bluga.net wrote:
> Revision
> 445
> Author
> lyaish
> Date
> 2006-03-19 20:05:01 -0600 (Sun, 19 Mar 2006)
> Log Message
> formEncode works with an id or an object
> fix target argument passed to makeFormAJAX was being overwritten in the
> handler function Modified Paths
> trunk/js/HTML_AJAX.js
> trunk/js/HTML_AJAX_lite.js
> trunk/js/Main.js
> Diff
> Modified: trunk/js/HTML_AJAX.js (444 => 445)
> --- trunk/js/HTML_AJAX.js       2006-03-20 00:49:18 UTC (rev 444)
> +++ trunk/js/HTML_AJAX.js       2006-03-20 02:05:01 UTC (rev 445)
> @@ -279,6 +279,9 @@
>      },
>      // turns a form into a urlencoded string
>      formEncode: function(form) {
> +        if (typeof form == 'string') {
> +            form = document.getElementById(form);
> +        }
>          var el, type, value, name, nameParts, useValue = true;
>          var out = '', tags = form.elements;
>          childLoop:
> @@ -408,14 +411,14 @@
>          }
>          form.HAOptions = options;
>          var handler = function(e) {
> -            var target = HTML_AJAX_Util.eventTarget(e);
> +            var form = HTML_AJAX_Util.eventTarget(e);
>
>              var valid = true;
>              if (preSubmit) {
>                  valid = preSubmit();
>              }
>                     if (valid) {
> -                          
> HTML_AJAX.formSubmit(target,target,form.HAOptions); +                      
>     HTML_AJAX.formSubmit(form,target,form.HAOptions); }
>              // cancel submission in IE
>              e.returnValue = false;
>
>
> Modified: trunk/js/HTML_AJAX_lite.js (444 => 445)
> --- trunk/js/HTML_AJAX_lite.js  2006-03-20 00:49:18 UTC (rev 444)
> +++ trunk/js/HTML_AJAX_lite.js  2006-03-20 02:05:01 UTC (rev 445)
> @@ -214,6 +214,9 @@
>  }
>  },
>  formEncode: function(form) {
> +if (typeof form == 'string') {
> +form = document.getElementById(form);
> +}
>  var el, type, value, name, nameParts, useValue = true;
>  var out = '', tags = form.elements;
>  childLoop:
> @@ -330,13 +333,13 @@
>  }
>  form.HAOptions = options;
>  var handler = function(e) {
> -var target = HTML_AJAX_Util.eventTarget(e);
> +var form = HTML_AJAX_Util.eventTarget(e);
>  var valid = true;
>  if (preSubmit) {
>  valid = preSubmit();
>  }
>  if (valid) {
> -HTML_AJAX.formSubmit(target,target,form.HAOptions);
> +HTML_AJAX.formSubmit(form,target,form.HAOptions);
>  }
>  e.returnValue = false;
>  if (e.preventDefault) {
>
>
> Modified: trunk/js/Main.js (444 => 445)
> --- trunk/js/Main.js    2006-03-20 00:49:18 UTC (rev 444)
> +++ trunk/js/Main.js    2006-03-20 02:05:01 UTC (rev 445)
> @@ -278,6 +278,9 @@
>      },
>      // turns a form into a urlencoded string
>      formEncode: function(form) {
> +        if (typeof form == 'string') {
> +            form = document.getElementById(form);
> +        }
>          var el, type, value, name, nameParts, useValue = true;
>          var out = '', tags = form.elements;
>          childLoop:
> @@ -407,14 +410,14 @@
>          }
>          form.HAOptions = options;
>          var handler = function(e) {
> -            var target = HTML_AJAX_Util.eventTarget(e);
> +            var form = HTML_AJAX_Util.eventTarget(e);
>
>              var valid = true;
>              if (preSubmit) {
>                  valid = preSubmit();
>              }
>                     if (valid) {
> -                          
> HTML_AJAX.formSubmit(target,target,form.HAOptions); +                      
>     HTML_AJAX.formSubmit(form,target,form.HAOptions); }
>              // cancel submission in IE
>              e.returnValue = false;